WuYongJie/CaiWuXiTong
1
0
Fork 0
Code Issues Pull Requests 7 Packages Projects Releases Wiki Activity

fix: 提升快递汇总导入上限至50万 (#214)

Browse Source 
运费差与其他附加费汇总的单次导入上限统一提升至 500,000 条，并补充超过旧上限的回归验证。
Co-authored-by: 苏木 <594326199@qq.com>
Co-committed-by: 苏木 <594326199@qq.com>
This commit is contained in:
苏木 2026-09-20 14:09:46 +08:00 committed by sumu
parent 0be09eab4b
commit 79588e88f2
2 changed files with 46 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
app/Business/CourierPayableSummaryStore.php
View File

@ -20,7 +20,10 @@ class CourierPayableSummaryStore
private const MAX_COLUMNS = 200;
private const MAX_ROWS = 10000;
private const MAX_ROWS_BY_PAGE = [
'freight-difference' => 500_000,
'other-surcharge-summary' => 500_000,
];
private const MAX_CELL_LENGTH = 10000;
@ -31,6 +34,13 @@ class CourierPayableSummaryStore
return self::PAGES[$page];
}
public function maxRows(string $page): int
{
$this->title($page);
return self::MAX_ROWS_BY_PAGE[$page];
}
/**
* @return array{version:int,headers:list<string>,rows:list<list<string>>,source_name:string,imported_at:string,imported_by:int|null}|null
*/
@ -72,7 +82,7 @@ class CourierPayableSummaryStore
$reader = IOFactory::createReaderForFile($file->getRealPath());
$reader->setReadDataOnly(true);
$spreadsheet = $reader->load($file->getRealPath());
[$headers, $rows] = $this->readSpreadsheet($spreadsheet);
[$headers, $rows] = $this->readSpreadsheet($spreadsheet, $page);
} catch (ValidationException $exception) {
throw $exception;
} catch (Throwable $exception) {
@ -128,8 +138,10 @@ class CourierPayableSummaryStore
}
/** @return array{0:list<string>,1:list<list<string>>} */
private function readSpreadsheet($spreadsheet): array
private function readSpreadsheet($spreadsheet, string $page): array
{
$maxRows = $this->maxRows($page);
foreach ($spreadsheet->getWorksheetIterator() as $worksheet) {
$rawRows = $worksheet->toArray(null, false, true, false);
$headerIndex = $this->headerIndex($rawRows);
@ -169,9 +181,9 @@ class CourierPayableSummaryStore
$rows[] = $row;
if (count($rows) > self::MAX_ROWS) {
if (count($rows) > $maxRows) {
throw ValidationException::withMessages([
'import' => '单次最多导入 ' . number_format(self::MAX_ROWS) . ' 条汇总数据，请拆分文件后重试。',
'import' => '单次最多导入 ' . number_format($maxRows) . ' 条汇总数据，请拆分文件后重试。',
]);
}
}

29
tests/Feature/Business/CourierPayableSummaryPagesTest.php
View File

@ -340,6 +340,35 @@ class CourierPayableSummaryPagesTest extends FeatureTestCase
$this->assertStringContainsString("\t=待确认", $content);
}
public function test_summary_imports_accept_more_than_ten_thousand_rows(): void
{
$store = app(CourierPayableSummaryStore::class);
$this->assertSame(500000, $store->maxRows('freight-difference'));
$this->assertSame(500000, $store->maxRows('other-surcharge-summary'));
$rows = ["快递公司,结算月份\n"];
for ($index = 1; $index <= 10001; $index++) {
$rows[] = "测试快递,2026-08\n";
}
foreach (['freight-difference', 'other-surcharge-summary'] as $page) {
$file = UploadedFile::fake()->createWithContent($page . '.csv', implode('', $rows));
$this->loginAs()->post(route('business.courier-payable-summaries.import', [
'summaryPage' => $page,
]), ['import' => $file])
->assertRedirect(route('business.pages.show', [
'section' => 'courier-payables',
'page' => $page,
]))
->assertSessionHas('success', '导入完成：10001 条数据，2 个字段。')
->assertSessionDoesntHaveErrors('import');
$snapshot = $store->snapshot((int) $this->company->id, $page);
$this->assertCount(10001, $snapshot['rows']);
}
}
public function test_summary_actions_require_the_matching_page_permission(): void
{
$this->withExceptionHandling();