fix: 修正评分项默认分值显示

This commit is contained in:
江林铖 2026-07-29 09:31:52 +08:00
parent 60d249e876
commit c45d77c48c
2 changed files with 41 additions and 6 deletions

View File

@ -650,6 +650,32 @@ describe('PerformanceSurveyAdminConfig', () => {
expect(screen.getByRole('button', { name: '添加评分项' })).toBeInTheDocument()
})
test('旧模板缺少单项满分时无需编辑即可显示模板默认分值', async () => {
const configuration = {
...config,
templates: config.templates.map((template: any) => template.id === 'template-1'
? {
...template,
versions: template.versions.map((version: any) => ({
...version,
definition: {
...version.definition,
questions: version.definition.questions.map(({ maxScore: _maxScore, ...question }: any) => question),
},
})),
}
: template),
}
const request = createRequest(configuration)
render(<PerformanceSurveyAdminConfig mode="templates" request={request} />)
fireEvent.click(await screen.findByRole('button', { name: '2. 评分项' }))
expect(screen.getByRole('button', { name: /评分项 1.*作品质量.*20 分.*完整/ })).toBeInTheDocument()
expect(screen.getByLabelText('满分')).toHaveValue(20)
expect(screen.getByText('已分配 20 × 3 个作品 = 60 / 60 分')).toBeInTheDocument()
})
test('发布前检查会定位问题,并持续反馈草稿保存状态', async () => {
const configuration = {
...config,

View File

@ -232,6 +232,14 @@ function surveyTypeLabel(type: TemplateDefinition['surveyType']) {
}[type]
}
function getEffectiveQuestionMaxScore(
definition: TemplateDefinition,
question: TemplateDefinition['questions'][number],
) {
const value = Number(question.maxScore ?? definition.questionMaxScore ?? 20)
return Number.isFinite(value) ? value : 0
}
function StatusDot({
label,
tone,
@ -343,13 +351,13 @@ function getTemplateReadiness(definition: TemplateDefinition): TemplateReadiness
? Math.max(1, Number(definition.requiredWorkItemCount || 1))
: 1
const questionTotal = definition.questions.reduce(
(sum, question) => sum + Number(question.maxScore || definition.questionMaxScore || 20),
(sum, question) => sum + getEffectiveQuestionMaxScore(definition, question),
0,
)
const allocatedTotal = questionTotal * workItemCount
const configuredTotal = Number(definition.maxTotal || 0)
const hasQuestionError = definition.questions.some((question) => (
!question.title.trim() || Number(question.maxScore || definition.questionMaxScore || 0) <= 0
!question.title.trim() || getEffectiveQuestionMaxScore(definition, question) <= 0
))
const scoreMatches = Math.round(allocatedTotal * 100) === Math.round(configuredTotal * 100)
const stages = definition.workflow.stages
@ -1747,7 +1755,7 @@ function QuestionEditor({
onChange: (definition: TemplateDefinition) => void
}) {
const perItemTotal = definition.questions.reduce(
(sum, question) => sum + Number(question.maxScore || definition.questionMaxScore || 20),
(sum, question) => sum + getEffectiveQuestionMaxScore(definition, question),
0,
)
const workItemCount = definition.surveyType === 'visual_case'
@ -1889,7 +1897,8 @@ function QuestionEditor({
)}
{definition.questions.map((question, index) => {
const expanded = expandedQuestionId === question.id
const complete = Boolean(question.title.trim()) && Number(question.maxScore || 0) > 0
const effectiveMaxScore = getEffectiveQuestionMaxScore(definition, question)
const complete = Boolean(question.title.trim()) && effectiveMaxScore > 0
const contentId = `question-editor-${question.id}`
return (
<div key={question.id} className={`border ${expanded ? 'border-[#9fb8ff]' : 'border-[#e2e2e2]'}`}>
@ -1908,7 +1917,7 @@ function QuestionEditor({
</span>
</span>
<span className="shrink-0 text-[12px] font-bold text-[#1a1c1c]">
{Number(question.maxScore || 0)} 分
{effectiveMaxScore} 分
</span>
<span className={`shrink-0 rounded-full px-2 py-0.5 text-[10px] font-bold ${
complete ? 'bg-[#eaf7ef] text-[#16794b]' : 'bg-[#fff0c7] text-[#7a4b00]'
@ -1944,7 +1953,7 @@ function QuestionEditor({
<input
type="number"
min="1"
value={question.maxScore || 20}
value={effectiveMaxScore}
disabled={!editable}
onChange={(event) => onChange({ ...definition, questions: definition.questions.map((item, itemIndex) => itemIndex === index ? { ...item, maxScore: Number(event.target.value) || 1 } : item) })}
className="h-11 min-w-0 w-full rounded border border-[#e2e2e2] px-3 text-[13px] outline-none focus:border-[#0050cb] disabled:bg-[#f4f4f4]"