ai-chatbot/packages/core/src/validation/validate-build-json.ts
Wassim SAMAD 6d5f041b48 fix(walls): bound wall miters, heal corrupt scenes, follow grid snap
Three related editor fixes surfaced while debugging a captured house
project that rendered an infinite wall and failed to load.

Infinite wall (core/systems/wall/wall-mitering.ts):
  Junction miters are line-line intersections, so the joint point sits
  ~halfThickness/sin(theta) from the junction. The only guard was an
  exact-parallel check (det < 1e-9), so two walls meeting at a shallow
  angle (a room-preset preview dragged onto an existing wall, or a wall
  drawn nearly collinear to its neighbour) produced a joint point far
  away — an infinite spike. Add a miter limit: reject joints farther
  than 10x half-thickness from the junction and fall back to a square
  joint, exactly like the parallel case.

Scene load failure (core/utils/heal-scene-graph.ts + validate-build-json
+ use-scene migrateNodes):
  Capture wall-merge could leave a `children: [null]` entry (see the
  matching merge-walls.ts fix in private-editor) and zero-length walls.
  `null` children fail wall schema validation, so the whole scene fails
  to load. Add a shared heal step — strip non-string child refs, drop
  childless zero-length walls — run on every load path: import
  validation now repairs instead of hard-failing (with a warning), and
  setScene heals on the prod project-load path too.

Grid snap (nodes slab/ceiling/spawn tools):
  These tools hardcoded a 0.5 m snap (Math.round(x*2)/2) and ignored the
  editor's grid-snap setting, so the cursor jumped by 0.5 while later
  vertices already followed the configured step. Route them through
  snapPointToGrid / snapScalar with gridSnapStep.

Adds unit tests for the miter limit and the heal step.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 11:30:39 -04:00

307 lines
8.5 KiB
TypeScript

import { AnyNode, type AnyNodeType } from '../schema/types'
import { healSceneNodes } from '../utils/heal-scene-graph'
export type ValidationSeverity = 'error' | 'warning'
export type ValidationIssue = {
severity: ValidationSeverity
code: string
message: string
nodeId?: string
}
export type BuildStats = {
total: number
byType: Partial<Record<AnyNodeType, number>>
unknownTypes: Record<string, number>
floorAreaM2: number
}
export type ParsedBuildJson = {
nodes: Record<string, unknown>
rootNodeIds: string[]
}
export type SchemaIssue = {
nodeId: string
nodeType: string
path: string
message: string
}
export type ValidateBuildJsonResult = {
ok: boolean
parsed: ParsedBuildJson | null
stats: BuildStats
errors: ValidationIssue[]
warnings: ValidationIssue[]
schemaIssues: SchemaIssue[]
schemaIssueCount: number
}
const KNOWN_TYPES = new Set<string>(
AnyNode.options.map((o) => o.shape.type.parse(undefined) as string),
)
function isPlainObject(value: unknown): value is Record<string, unknown> {
return typeof value === 'object' && value !== null && !Array.isArray(value)
}
function polygonAreaM2(points: ReadonlyArray<readonly [number, number]>): number {
if (points.length < 3) return 0
let area = 0
for (let i = 0; i < points.length; i++) {
const a = points[i]
const b = points[(i + 1) % points.length]
if (!a || !b) return 0
area += a[0] * b[1] - b[0] * a[1]
}
return Math.abs(area) / 2
}
function isPointArray(value: unknown): value is ReadonlyArray<readonly [number, number]> {
if (!Array.isArray(value)) return false
return value.every(
(p) =>
Array.isArray(p) && p.length === 2 && typeof p[0] === 'number' && typeof p[1] === 'number',
)
}
/**
* Pre-flight validator for `{ nodes, rootNodeIds }` build JSON loaded via
* Load Build (drag-drop, IFC converter output, hand-edited files).
*
* Reports issues without mutating; the scene store still owns migration
* and orphan cleanup at import time. Hard errors mean the file is
* structurally unusable and import should be blocked.
*/
export function validateBuildJson(input: unknown): ValidateBuildJsonResult {
const errors: ValidationIssue[] = []
const warnings: ValidationIssue[] = []
const schemaIssues: SchemaIssue[] = []
const stats: BuildStats = { total: 0, byType: {}, unknownTypes: {}, floorAreaM2: 0 }
if (!isPlainObject(input)) {
errors.push({
severity: 'error',
code: 'not_an_object',
message: 'File is not a JSON object.',
})
return {
ok: false,
parsed: null,
stats,
errors,
warnings,
schemaIssues,
schemaIssueCount: 0,
}
}
const nodesRaw = input.nodes
const rootNodeIdsRaw = input.rootNodeIds
if (!isPlainObject(nodesRaw)) {
errors.push({
severity: 'error',
code: 'missing_nodes',
message: 'Missing or invalid "nodes" — expected an object of id → node.',
})
}
if (!Array.isArray(rootNodeIdsRaw) || !rootNodeIdsRaw.every((id) => typeof id === 'string')) {
errors.push({
severity: 'error',
code: 'missing_root_node_ids',
message: 'Missing or invalid "rootNodeIds" — expected an array of node IDs.',
})
}
if (errors.length > 0) {
return {
ok: false,
parsed: null,
stats,
errors,
warnings,
schemaIssues,
schemaIssueCount: 0,
}
}
// Heal known pre-existing corruption (null children, zero-length walls) up
// front, so a scene saved before the source fixes still imports instead of
// hard-failing schema validation. `parsed` below carries the repaired nodes.
const { nodes, droppedWallIds, strippedChildRefs } = healSceneNodes(
nodesRaw as Record<string, unknown>,
)
const rootNodeIds = rootNodeIdsRaw as string[]
if (strippedChildRefs > 0 || droppedWallIds.length > 0) {
warnings.push({
severity: 'warning',
code: 'auto_repaired',
message: `Repaired on import: removed ${strippedChildRefs} invalid child reference${strippedChildRefs === 1 ? '' : 's'} and ${droppedWallIds.length} zero-length wall${droppedWallIds.length === 1 ? '' : 's'}.`,
})
}
if (rootNodeIds.length === 0) {
errors.push({
severity: 'error',
code: 'empty_root_node_ids',
message: '"rootNodeIds" is empty — no entry point into the scene.',
})
}
let validRootCount = 0
let mismatchedKeyCount = 0
let schemaFailureCount = 0
for (const [key, value] of Object.entries(nodes)) {
if (!isPlainObject(value)) {
warnings.push({
severity: 'warning',
code: 'node_not_object',
message: `Node "${key}" is not an object.`,
nodeId: key,
})
continue
}
stats.total += 1
const id = typeof value.id === 'string' ? value.id : null
const type = typeof value.type === 'string' ? value.type : null
const parentId = typeof value.parentId === 'string' ? value.parentId : null
if (id && id !== key) {
mismatchedKeyCount += 1
}
if (!type) {
warnings.push({
severity: 'warning',
code: 'missing_type',
message: `Node "${key}" has no "type" field.`,
nodeId: key,
})
continue
}
if (KNOWN_TYPES.has(type)) {
const t = type as AnyNodeType
stats.byType[t] = (stats.byType[t] ?? 0) + 1
const parseResult = AnyNode.safeParse(value)
if (!parseResult.success) {
schemaFailureCount += 1
const issue = parseResult.error.issues[0]
schemaIssues.push({
nodeId: key,
nodeType: type,
path: issue ? issue.path.join('.') : '',
message: issue ? issue.message : 'schema mismatch',
})
}
if (type === 'slab') {
const polygon = (value as { polygon?: unknown }).polygon
if (isPointArray(polygon)) {
let area = polygonAreaM2(polygon)
const holes = (value as { holes?: unknown }).holes
if (Array.isArray(holes)) {
for (const hole of holes) {
if (isPointArray(hole)) area -= polygonAreaM2(hole)
}
}
stats.floorAreaM2 += Math.max(0, area)
}
}
} else {
stats.unknownTypes[type] = (stats.unknownTypes[type] ?? 0) + 1
}
if (parentId && !(parentId in nodes)) {
warnings.push({
severity: 'warning',
code: 'orphan_parent',
message: `Node "${key}" has parentId "${parentId}" which is not in the file (will be dropped on import).`,
nodeId: key,
})
}
}
if (mismatchedKeyCount > 0) {
warnings.push({
severity: 'warning',
code: 'key_id_mismatch',
message: `${mismatchedKeyCount} node${mismatchedKeyCount === 1 ? '' : 's'} have a key that does not match their "id" field.`,
})
}
const unknownTypeNames = Object.keys(stats.unknownTypes)
if (unknownTypeNames.length > 0) {
const totalUnknown = unknownTypeNames.reduce((n, t) => n + stats.unknownTypes[t]!, 0)
warnings.push({
severity: 'warning',
code: 'unknown_types',
message: `${totalUnknown} node${totalUnknown === 1 ? '' : 's'} use unknown type${unknownTypeNames.length === 1 ? '' : 's'}: ${unknownTypeNames.join(', ')}.`,
})
}
if (schemaFailureCount > 0) {
errors.push({
severity: 'error',
code: 'schema_failure',
message: `${schemaFailureCount} node${schemaFailureCount === 1 ? '' : 's'} did not match the expected schema. See details below — these would cause the editor to crash on load.`,
})
}
for (const id of rootNodeIds) {
if (id in nodes) {
validRootCount += 1
} else {
warnings.push({
severity: 'warning',
code: 'orphan_root',
message: `Root node "${id}" is not in the file (will be ignored on import).`,
nodeId: id,
})
}
}
if (rootNodeIds.length > 0 && validRootCount === 0) {
errors.push({
severity: 'error',
code: 'no_valid_roots',
message: 'None of the rootNodeIds point to a node in the file.',
})
}
const hasBuildingOrSite = (stats.byType.building ?? 0) > 0 || (stats.byType.site ?? 0) > 0
if (!hasBuildingOrSite) {
warnings.push({
severity: 'warning',
code: 'no_building',
message: 'No site or building node found.',
})
}
if ((stats.byType.level ?? 0) === 0) {
warnings.push({
severity: 'warning',
code: 'no_levels',
message: 'No level nodes found.',
})
}
const ok = errors.length === 0
return {
ok,
parsed: ok ? { nodes, rootNodeIds } : null,
stats,
errors,
warnings,
schemaIssues,
schemaIssueCount: schemaFailureCount,
}
}