Ships the combined filesystem/Supabase storage adapter + MCP scene lifecycle tools + Next.js API routes + editor /scene/[id] route, so an MCP save is directly openable at /scene/<id> without any injection hack. End-to-end verified: 10/10 e2e steps pass. Storage (A1/A2/A3): - SceneStore interface + error classes + slug helpers - FilesystemSceneStore at $PASCAL_DATA_DIR (defaults XDG/~/.pascal) with atomic writes, .index sidecar, optimistic locking - SupabaseSceneStore with scenes + scene_revisions tables, RLS migration SQL, mock-backed unit tests - createSceneStore(env) auto-selects based on SUPABASE_URL + SUPABASE_SERVICE_ROLE_KEY MCP tools (A4, A8, A9, A10): - save_scene / load_scene / list_scenes / delete_scene / rename_scene - list_templates / create_from_template (3 seed templates: empty-studio, two-bedroom, garden-house) - generate_variants (7 mutation kinds, seeded RNG, save=true|false) - photo_to_scene (vision sampling → scene graph → save) Editor (A5, A6): - /api/scenes + /api/scenes/[id] with RFC 7232 If-Match locking - /scene/[id] and /scenes route pages with save button, SceneLoader - Removed the window.__pascalScene dev injection hack Security + UX edges (A7, A8): - AssetUrl Zod validator: asset:// blob: data:image/ /path https: (http://localhost for dev) + PASCAL_ALLOWED_ASSET_ORIGINS env allowlist. Hardens scan.url, guide.url, item.asset.src, material.texture.url, MaterialMaps.*Map - Auto-frame camera on empty→non-empty scene transition (camera-controls:fit-scene emitter event) Shared utilities: - rehydrateSiteChildren() extracted to packages/mcp/src/lib/ and used by both create-from-template and generate-variants to work around the SiteNode.children-as-objects vs. ids inconsistency (CROSS_CUTTING §2) - Storage + MCP subpath exports added to packages/mcp/package.json (CROSS_CUTTING §4) Tests: 293 pass / 0 fail across 40 files (was 142 pre-Phase-7). Biome: clean. Phase-7 e2e script at packages/mcp/test-reports/phase7-e2e.ts: MCP HTTP + editor Next.js both point at $PASCAL_DATA_DIR = /tmp/pascal-e2e, save_scene from MCP, GET /api/scenes/<id> from editor server, /scenes list page renders all saved scenes, scene page renders SceneLoader, delete_scene works. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
410 lines
11 KiB
TypeScript
410 lines
11 KiB
TypeScript
import { describe, expect, test } from 'bun:test'
|
|
import type { SceneGraph } from '@pascal-app/core/clone-scene-graph'
|
|
import type { AnyNodeId } from '@pascal-app/core/schema'
|
|
import { applyMutation, mulberry32 } from './mutations'
|
|
|
|
function makeBaseGraph(): SceneGraph {
|
|
const nodes: SceneGraph['nodes'] = {
|
|
site_a: {
|
|
object: 'node',
|
|
id: 'site_a',
|
|
type: 'site',
|
|
parentId: null,
|
|
visible: true,
|
|
metadata: {},
|
|
polygon: {
|
|
type: 'polygon',
|
|
points: [
|
|
[-10, -10],
|
|
[10, -10],
|
|
[10, 10],
|
|
[-10, 10],
|
|
],
|
|
},
|
|
children: [],
|
|
},
|
|
building_a: {
|
|
object: 'node',
|
|
id: 'building_a',
|
|
type: 'building',
|
|
parentId: 'site_a',
|
|
visible: true,
|
|
metadata: {},
|
|
position: [0, 0, 0],
|
|
rotation: [0, 0, 0],
|
|
children: ['level_a'],
|
|
},
|
|
level_a: {
|
|
object: 'node',
|
|
id: 'level_a',
|
|
type: 'level',
|
|
parentId: 'building_a',
|
|
visible: true,
|
|
metadata: {},
|
|
children: ['wall_n', 'wall_s', 'wall_e', 'wall_w', 'wall_mid', 'zone_kitchen', 'zone_living'],
|
|
},
|
|
wall_n: {
|
|
object: 'node',
|
|
id: 'wall_n',
|
|
type: 'wall',
|
|
parentId: 'level_a',
|
|
visible: true,
|
|
metadata: {},
|
|
start: [-10, 10],
|
|
end: [10, 10],
|
|
thickness: 0.1,
|
|
height: 2.5,
|
|
children: [],
|
|
frontSide: 'unknown',
|
|
backSide: 'unknown',
|
|
},
|
|
wall_s: {
|
|
object: 'node',
|
|
id: 'wall_s',
|
|
type: 'wall',
|
|
parentId: 'level_a',
|
|
visible: true,
|
|
metadata: {},
|
|
start: [-10, -10],
|
|
end: [10, -10],
|
|
thickness: 0.1,
|
|
height: 2.5,
|
|
children: [],
|
|
frontSide: 'unknown',
|
|
backSide: 'unknown',
|
|
},
|
|
wall_e: {
|
|
object: 'node',
|
|
id: 'wall_e',
|
|
type: 'wall',
|
|
parentId: 'level_a',
|
|
visible: true,
|
|
metadata: {},
|
|
start: [10, -10],
|
|
end: [10, 10],
|
|
thickness: 0.1,
|
|
height: 2.5,
|
|
children: [],
|
|
frontSide: 'unknown',
|
|
backSide: 'unknown',
|
|
},
|
|
wall_w: {
|
|
object: 'node',
|
|
id: 'wall_w',
|
|
type: 'wall',
|
|
parentId: 'level_a',
|
|
visible: true,
|
|
metadata: {},
|
|
start: [-10, -10],
|
|
end: [-10, 10],
|
|
thickness: 0.1,
|
|
height: 2.5,
|
|
children: [],
|
|
frontSide: 'unknown',
|
|
backSide: 'unknown',
|
|
},
|
|
wall_mid: {
|
|
object: 'node',
|
|
id: 'wall_mid',
|
|
type: 'wall',
|
|
parentId: 'level_a',
|
|
visible: true,
|
|
metadata: {},
|
|
start: [-5, 0],
|
|
end: [5, 0],
|
|
thickness: 0.1,
|
|
height: 2.5,
|
|
children: ['door_mid'],
|
|
frontSide: 'unknown',
|
|
backSide: 'unknown',
|
|
},
|
|
door_mid: {
|
|
object: 'node',
|
|
id: 'door_mid',
|
|
type: 'door',
|
|
parentId: 'wall_mid',
|
|
visible: true,
|
|
metadata: {},
|
|
position: [0, 0, 0],
|
|
rotation: [0, 0, 0],
|
|
wallId: 'wall_mid',
|
|
width: 0.9,
|
|
height: 2.1,
|
|
frameThickness: 0.05,
|
|
frameDepth: 0.07,
|
|
threshold: true,
|
|
thresholdHeight: 0.02,
|
|
hingesSide: 'left',
|
|
swingDirection: 'inward',
|
|
segments: [],
|
|
handle: true,
|
|
handleHeight: 1.05,
|
|
handleSide: 'right',
|
|
contentPadding: [0.04, 0.04],
|
|
doorCloser: false,
|
|
panicBar: false,
|
|
panicBarHeight: 1.0,
|
|
},
|
|
zone_kitchen: {
|
|
object: 'node',
|
|
id: 'zone_kitchen',
|
|
type: 'zone',
|
|
parentId: 'level_a',
|
|
visible: true,
|
|
metadata: {},
|
|
name: 'Kitchen',
|
|
polygon: [
|
|
[-5, 0],
|
|
[5, 0],
|
|
[5, 10],
|
|
[-5, 10],
|
|
],
|
|
color: '#ff0000',
|
|
},
|
|
zone_living: {
|
|
object: 'node',
|
|
id: 'zone_living',
|
|
type: 'zone',
|
|
parentId: 'level_a',
|
|
visible: true,
|
|
metadata: {},
|
|
name: 'Living',
|
|
polygon: [
|
|
[-5, -10],
|
|
[5, -10],
|
|
[5, 0],
|
|
[-5, 0],
|
|
],
|
|
color: '#00ff00',
|
|
},
|
|
fence_1: {
|
|
object: 'node',
|
|
id: 'fence_1',
|
|
type: 'fence',
|
|
parentId: 'site_a',
|
|
visible: true,
|
|
metadata: {},
|
|
start: [-8, -8],
|
|
end: [8, -8],
|
|
height: 1.8,
|
|
thickness: 0.08,
|
|
baseHeight: 0.22,
|
|
postSpacing: 2,
|
|
postSize: 0.1,
|
|
topRailHeight: 0.04,
|
|
groundClearance: 0,
|
|
edgeInset: 0.015,
|
|
baseStyle: 'grounded',
|
|
color: '#ffffff',
|
|
style: 'slat',
|
|
},
|
|
} as unknown as SceneGraph['nodes']
|
|
return {
|
|
nodes,
|
|
rootNodeIds: ['site_a'] as AnyNodeId[],
|
|
}
|
|
}
|
|
|
|
describe('mulberry32', () => {
|
|
test('is deterministic for the same seed', () => {
|
|
const a = mulberry32(42)
|
|
const b = mulberry32(42)
|
|
for (let i = 0; i < 10; i++) {
|
|
expect(a()).toBe(b())
|
|
}
|
|
})
|
|
test('produces values in [0, 1)', () => {
|
|
const rng = mulberry32(7)
|
|
for (let i = 0; i < 100; i++) {
|
|
const v = rng()
|
|
expect(v).toBeGreaterThanOrEqual(0)
|
|
expect(v).toBeLessThan(1)
|
|
}
|
|
})
|
|
})
|
|
|
|
describe('applyMutation: wall-thickness', () => {
|
|
test('assigns every wall a thickness from the fixed set', () => {
|
|
const rng = mulberry32(1)
|
|
const out = applyMutation(makeBaseGraph(), rng, 'wall-thickness')
|
|
const allowed = new Set([0.1, 0.15, 0.2, 0.25])
|
|
let walls = 0
|
|
for (const node of Object.values(out.nodes)) {
|
|
if (node.type !== 'wall') continue
|
|
walls++
|
|
expect(allowed.has((node as { thickness: number }).thickness)).toBe(true)
|
|
}
|
|
expect(walls).toBeGreaterThan(0)
|
|
})
|
|
|
|
test('does not mutate the input graph', () => {
|
|
const base = makeBaseGraph()
|
|
const before = JSON.stringify(base)
|
|
applyMutation(base, mulberry32(5), 'wall-thickness')
|
|
expect(JSON.stringify(base)).toBe(before)
|
|
})
|
|
})
|
|
|
|
describe('applyMutation: wall-height', () => {
|
|
test('assigns every wall a height from the fixed set', () => {
|
|
const rng = mulberry32(2)
|
|
const out = applyMutation(makeBaseGraph(), rng, 'wall-height')
|
|
const allowed = new Set([2.4, 2.6, 2.7, 3.0])
|
|
for (const node of Object.values(out.nodes)) {
|
|
if (node.type !== 'wall') continue
|
|
expect(allowed.has((node as { height: number }).height)).toBe(true)
|
|
}
|
|
})
|
|
})
|
|
|
|
describe('applyMutation: zone-labels', () => {
|
|
test('shuffles labels but preserves the set', () => {
|
|
const base = makeBaseGraph()
|
|
const rng = mulberry32(3)
|
|
const out = applyMutation(base, rng, 'zone-labels')
|
|
const before = new Set<string>()
|
|
for (const node of Object.values(base.nodes)) {
|
|
if (node.type === 'zone') before.add((node as { name: string }).name)
|
|
}
|
|
const after = new Set<string>()
|
|
for (const node of Object.values(out.nodes)) {
|
|
if (node.type === 'zone') after.add((node as { name: string }).name)
|
|
}
|
|
expect(after).toEqual(before)
|
|
})
|
|
})
|
|
|
|
describe('applyMutation: room-proportions', () => {
|
|
test('only nudges interior walls, leaves perimeter alone', () => {
|
|
const base = makeBaseGraph()
|
|
const rng = mulberry32(4)
|
|
const out = applyMutation(base, rng, 'room-proportions')
|
|
// Perimeter wall should be unchanged.
|
|
const n = out.nodes.wall_n as { start: [number, number]; end: [number, number] }
|
|
expect(n.start).toEqual([-10, 10])
|
|
expect(n.end).toEqual([10, 10])
|
|
// Interior wall should (usually) be different.
|
|
const mid = out.nodes.wall_mid as { start: [number, number]; end: [number, number] }
|
|
const midBase = base.nodes.wall_mid as { start: [number, number]; end: [number, number] }
|
|
const changed =
|
|
mid.start[0] !== midBase.start[0] ||
|
|
mid.start[1] !== midBase.start[1] ||
|
|
mid.end[0] !== midBase.end[0] ||
|
|
mid.end[1] !== midBase.end[1]
|
|
expect(changed).toBe(true)
|
|
})
|
|
})
|
|
|
|
describe('applyMutation: open-plan', () => {
|
|
test('removes exactly one interior wall and its attached openings', () => {
|
|
const base = makeBaseGraph()
|
|
const baseWallCount = Object.values(base.nodes).filter((n) => n.type === 'wall').length
|
|
const rng = mulberry32(5)
|
|
const out = applyMutation(base, rng, 'open-plan')
|
|
const afterWallCount = Object.values(out.nodes).filter((n) => n.type === 'wall').length
|
|
expect(afterWallCount).toBe(baseWallCount - 1)
|
|
// Interior wall `wall_mid` had a door — both should be gone.
|
|
expect(out.nodes.wall_mid).toBeUndefined()
|
|
expect(out.nodes.door_mid).toBeUndefined()
|
|
})
|
|
|
|
test('skips gracefully when there are no interior walls', () => {
|
|
const graph: SceneGraph = {
|
|
nodes: {
|
|
site_a: {
|
|
object: 'node',
|
|
id: 'site_a',
|
|
type: 'site',
|
|
parentId: null,
|
|
visible: true,
|
|
metadata: {},
|
|
polygon: {
|
|
type: 'polygon',
|
|
points: [
|
|
[-10, -10],
|
|
[10, -10],
|
|
[10, 10],
|
|
[-10, 10],
|
|
],
|
|
},
|
|
children: [],
|
|
},
|
|
wall_n: {
|
|
object: 'node',
|
|
id: 'wall_n',
|
|
type: 'wall',
|
|
parentId: 'site_a',
|
|
visible: true,
|
|
metadata: {},
|
|
start: [-10, 10],
|
|
end: [10, 10],
|
|
thickness: 0.1,
|
|
height: 2.5,
|
|
children: [],
|
|
frontSide: 'unknown',
|
|
backSide: 'unknown',
|
|
},
|
|
} as unknown as SceneGraph['nodes'],
|
|
rootNodeIds: ['site_a'] as AnyNodeId[],
|
|
}
|
|
const out = applyMutation(graph, mulberry32(9), 'open-plan')
|
|
expect(Object.keys(out.nodes)).toEqual(Object.keys(graph.nodes))
|
|
})
|
|
})
|
|
|
|
describe('applyMutation: door-positions', () => {
|
|
test('sets every door wallT in [0.2, 0.8]', () => {
|
|
const rng = mulberry32(6)
|
|
const out = applyMutation(makeBaseGraph(), rng, 'door-positions')
|
|
for (const node of Object.values(out.nodes)) {
|
|
if (node.type !== 'door') continue
|
|
const t = (node as { wallT?: number }).wallT
|
|
expect(typeof t).toBe('number')
|
|
expect(t as number).toBeGreaterThanOrEqual(0.2)
|
|
expect(t as number).toBeLessThanOrEqual(0.8)
|
|
}
|
|
})
|
|
})
|
|
|
|
describe('applyMutation: fence-style', () => {
|
|
test('sets every fence style to one of privacy/slat/rail', () => {
|
|
const rng = mulberry32(7)
|
|
const out = applyMutation(makeBaseGraph(), rng, 'fence-style')
|
|
const allowed = new Set(['privacy', 'slat', 'rail'])
|
|
for (const node of Object.values(out.nodes)) {
|
|
if (node.type !== 'fence') continue
|
|
expect(allowed.has((node as { style: string }).style)).toBe(true)
|
|
}
|
|
})
|
|
})
|
|
|
|
describe('applyMutation: no-op behaviour', () => {
|
|
test('wall-thickness on a graph with no walls leaves nodes unchanged', () => {
|
|
const graph: SceneGraph = {
|
|
nodes: {
|
|
site_a: {
|
|
object: 'node',
|
|
id: 'site_a',
|
|
type: 'site',
|
|
parentId: null,
|
|
visible: true,
|
|
metadata: {},
|
|
polygon: {
|
|
type: 'polygon',
|
|
points: [
|
|
[-1, -1],
|
|
[1, -1],
|
|
[1, 1],
|
|
[-1, 1],
|
|
],
|
|
},
|
|
children: [],
|
|
},
|
|
} as unknown as SceneGraph['nodes'],
|
|
rootNodeIds: ['site_a'] as AnyNodeId[],
|
|
}
|
|
const out = applyMutation(graph, mulberry32(8), 'wall-thickness')
|
|
expect(JSON.stringify(out.nodes)).toBe(JSON.stringify(graph.nodes))
|
|
})
|
|
})
|